Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket write in iterations #403

Merged
merged 8 commits into from
Jan 9, 2025
Merged

Websocket write in iterations #403

merged 8 commits into from
Jan 9, 2025

Conversation

joente
Copy link
Member

@joente joente commented Jan 9, 2025

Description

This is an attempt to see if large responses succeed is certain circumstances. Some clients experience the following error when large responses need to be written:

[I 2025-01-09 04:24:49] [2025/01/09 04:24:49:4822] E: lws_buflist_append_segment: buflist reached sanity limit
[E 2025-01-09 04:24:49] ERROR -1; writing to WebSocket

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Test ws and wss using an alpha version

Test Configuration:

  • Use both python and different browsers for testing the websocket connection

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@joente joente added the bug label Jan 9, 2025
@joente joente self-assigned this Jan 9, 2025
@joente joente merged commit b0eacf3 into main Jan 9, 2025
1 check passed
@joente joente deleted the largews branch January 9, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant