This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
fix: better handle token registration errors #44
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the token registration error handling.
The problem was that without an explicit
gasLimit
, the token registration transaction would fail without clear error in case of for instance insufficient funds. This came from the lack of explicitgasLimit
in that transaction sending (gas estimation isn't working well with custom params).The PR also introduces a design change: the top-context
setErrors
helper function is now called in the component rather than the hook. This may be replicated to all other hooks in the future, as the presentation layer should cover the error display.Fixes TOO-410
PR Checklist: