Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for threadsafe logging. #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

friedbrice
Copy link
Contributor

Re: #14

@friedbrice
Copy link
Contributor Author

Re: #15, too.

@chris-martin
Copy link
Member

Finally getting back to this 😓

When run as an executable, not all the log messages get printed, because main doesn't join to the "sing" threads, so it quits before they finish. I'm considering using the async package instead of forkIO so we can have an easy facility to wait for thread termination.

@friedbrice
Copy link
Contributor Author

  (log, print) <- do

I probably shouldn't be shadowing Prelude symbols, either 🙃

I'll play with this today and push what i end up with.

@chris-martin
Copy link
Member

Hey, good to hear from you! Check out my PR, I've had some other thoughts as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants