Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(create-vite): add hint for external CLIs #19157

Merged
merged 2 commits into from
Jan 23, 2025
Merged

feat(create-vite): add hint for external CLIs #19157

merged 2 commits into from
Jan 23, 2025

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jan 7, 2025

Description

Adds a hint for external CLIs so it's clear that it's not part of create-vite

image

@patak-dev
Copy link
Member

This looks great! A lot better than I expected. I like it more than moving to the simple create-xxx for the labels, so +1 from my side.

I would like we review the Customize with create-xxx options and find better labels for them. Maybe Official Vue Starter, Official Preact Starter. Let's do that in a separate PR.

@patak-dev patak-dev added p2-nice-to-have Not breaking anything but nice to have (priority) feat: create-vite create-vite package labels Jan 7, 2025
@patak-dev patak-dev added this to the 6.1 milestone Jan 7, 2025
sapphi-red
sapphi-red approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice ✨

@patak-dev patak-dev mentioned this pull request Jan 8, 2025
Open
@patak-dev patak-dev merged commit b9a4cc6 into main Jan 23, 2025
15 checks passed
@patak-dev patak-dev deleted the create-vite-external-hint branch January 23, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
feat: create-vite create-vite package p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@bluwy @patak-dev @sapphi-red