Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade nwaku to 0.34.0 and update tests suite for compatibility #2170

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

danisharora099
Copy link
Collaborator

@danisharora099 danisharora099 commented Oct 9, 2024

Description

This pull request upgrades the nwaku dependency to version 0.34.0 and includes various improvements and fixes in the test suite to accommodate this upgrade. Key changes include:

  • Updates to the CI workflow configuration to use the new nwaku version.
  • Enhancements and adjustments to the test suite:
    • service nodes (nwaku) spawned together connect to each other via Relay
    • adds deduplication logic for ecies encrypted payloads to avoid being considered as multiple messages
    • single node lightpush tests now expected to fail (nwaku requires minimum 1 peer part of the mesh)

Notes

Contribution checklist:

  • covered by unit tests;
  • covered by e2e test;
  • add ! in title if breaks public API;

@danisharora099 danisharora099 changed the title chore: upgrade to 0.32 chore: upgrade nwaku to 0.32 Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 86.73 KB (0%) 1.8 s (0%) 837 ms (+24.85% 🔺) 2.6 s
Waku Simple Light Node 137.15 KB (0%) 2.8 s (0%) 1.3 s (+16.37% 🔺) 4.1 s
ECIES encryption 22.88 KB (0%) 458 ms (0%) 386 ms (+41.47% 🔺) 843 ms
Symmetric encryption 22.37 KB (0%) 448 ms (0%) 244 ms (-38.96% 🔽) 692 ms
DNS discovery 70.54 KB (0%) 1.5 s (0%) 527 ms (-23.4% 🔽) 2 s
Peer Exchange discovery 71.82 KB (0%) 1.5 s (0%) 690 ms (+14.39% 🔺) 2.2 s
Local Peer Cache Discovery 65.17 KB (0%) 1.4 s (0%) 696 ms (-7.04% 🔽) 2 s
Privacy preserving protocols 76.23 KB (0%) 1.6 s (0%) 747 ms (+2.82% 🔺) 2.3 s
Waku Filter 81.02 KB (0%) 1.7 s (0%) 883 ms (-7.96% 🔽) 2.6 s
Waku LightPush 75.73 KB (0%) 1.6 s (0%) 773 ms (-14.58% 🔽) 2.3 s
History retrieval protocols 77.69 KB (0%) 1.6 s (0%) 765 ms (+6.59% 🔺) 2.4 s
Deterministic Message Hashing 7.39 KB (0%) 148 ms (0%) 173 ms (+102.74% 🔺) 321 ms

@danisharora099 danisharora099 changed the title chore: upgrade nwaku to 0.32 chore: upgrade nwaku to 0.33 Oct 10, 2024
@danisharora099 danisharora099 changed the title chore: upgrade nwaku to 0.33 chore: upgrade nwaku to 0.34.0 Jan 17, 2025
@danisharora099 danisharora099 force-pushed the chore/upgrade-nwaku branch 3 times, most recently from e27033a to c48d1b8 Compare January 20, 2025 12:03
@danisharora099 danisharora099 marked this pull request as ready for review January 22, 2025 12:11
@danisharora099 danisharora099 requested a review from a team as a code owner January 22, 2025 12:11
@danisharora099 danisharora099 linked an issue Jan 22, 2025 that may be closed by this pull request
@danisharora099 danisharora099 changed the title chore: upgrade nwaku to 0.34.0 chore: upgrade nwaku to 0.34.0 and update tests suite for compatibility Jan 22, 2025
@weboko
Copy link
Collaborator

weboko commented Jan 23, 2025

Is it ready for review? Both test steps has failed :(

@danisharora099
Copy link
Collaborator Author

Is it ready for review? Both test steps has failed :(

All of the tests seem to pass, but the CI runner doesn't seem to exit out of the process
Investigating

@danisharora099 danisharora099 force-pushed the chore/upgrade-nwaku branch 3 times, most recently from c07f354 to 7d681e6 Compare January 29, 2025 13:49
@danisharora099 danisharora099 force-pushed the chore/upgrade-nwaku branch 4 times, most recently from f23e214 to 1159b97 Compare January 29, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: upgrade nwaku to 0.34.0 and check interop tests
2 participants