-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: CI browser/karma #2204
Merged
Merged
fix: CI browser/karma #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
weboko
reviewed
Jan 15, 2025
|
||
process.env.CHROME_BIN = playwright.chromium.executablePath(); | ||
process.env.FIREFOX_BIN = playwright.firefox.executablePath(); | ||
|
||
module.exports = function (config) { | ||
config.set({ | ||
const configuration = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: these lines actually do not change anything
weboko
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Problem
Browser tests in CI are failing due to Chrome sandbox issues in the container environment. The specific error indicates that the sandbox cannot be initialized in the Ubuntu environment:
Additionally, Firefox tests were potentially affected by container permission issues due to missing HOME directory configuration.
Solution
Updated the CI workflow to properly configure the container environment:
Modified Karma configuration to use CI-specific Chrome launcher with appropriate sandbox flags:
Notes
Contribution checklist:
!
in title if breaks public API (not needed - internal CI change only)