Use one-way bindings for wpt-metadata and wpt-amend-metadata #4187
Conversation
| @@ -100,7 +100,7 @@ class WPTMetadata extends PathInfo(LoadingState(PolymerElement)) { | |||
| ></wpt-metadata-node> | |||
| </template> | |||
| </iron-collapse> | |||
| <paper-button id="metadata-toggle" onclick="[[openCollapsible]]"> | |||
There was a problem hiding this comment.
nit: this variable should be removed in the file.
| @@ -195,7 +195,7 @@ class TestFileResultsTable extends WPTFlags(Pluralizer(AmendMetadataMixin(WPTCol | |||
| </template> | |||
| </tbody> | |||
| </table> | |||
| <wpt-amend-metadata id="amend" selected-metadata="{{selectedMetadata}}" path="[[path]]"></wpt-amend-metadata> | |||
| <wpt-amend-metadata id="amend" selected-metadata="[[selectedMetadata]]" path="[[path]]"></wpt-amend-metadata> | |||
There was a problem hiding this comment.
we still need to listen to the change in selectedMetadata in test-file-results-table.js, because it is used to clear the selected cells UI when the triage UI is dismissed through clearSelectedCells. I will post a recorded video clips to demonstrate that
There was a problem hiding this comment.
Good catch! It's actually the method in wpt-results.js that clears the cells, but I changed it here for consistency.
| triage-notifier="[[triageNotifier]]"></wpt-metadata> | ||
| </template> | ||
| <wpt-amend-metadata id="amend" selected-metadata="{{selectedMetadata}}" path="[[path]]"></wpt-amend-metadata> | ||
| <wpt-amend-metadata id="amend" selected-metadata="[[selectedMetadata]]" path="[[path]]"></wpt-amend-metadata> |
There was a problem hiding this comment.
ditto. Still need a EventListener for selectedMetadata
| metadata-map="{{metadataMap}}" | ||
| label-map="{{labelMap}}" | ||
| metadata-map="[[metadataMap]]" | ||
| label-map="[[labelMap}]]" |
There was a problem hiding this comment.
wpt-results still need to add EventListener for metadataMap and labelMap because the data is being fetched inside of . Once it is fetched, notifies wpt-results that data has been fetched. Then wpt-results updates the inline labels UI in the test results.
Screen.recording.2025-01-17.4.15.36.PM.webmHow the upward data binding for |
|
This is ready now for another review pass. |
This migration was a bit larger than usual due to the fact that the metadata component and the triage component interact so closely. The main changes are:
notify: trueand change double angle brackets to double brackets.