-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and run pre-commit config #172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Is it possible to disable the hooks for vendor
directory?
0745453
to
2fbfdb0
Compare
Let me try to run the RTTIDumper quickly to check the last commit and I believe this should be clean 👍 |
2fbfdb0
to
4900f83
Compare
@wopss Seems the generation is clean now 👍 Also a bit unsure after I saw Natives.cpp if it should not be including *-inl.hpp files instead tbh 🤔 But left that one as-is. |
Oh and to this - excluded, sorry... Fell out of mind when it was not a review comment 😄 Fixed in latest commit |
699d145
to
11d085e
Compare
We don't have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Requires Python 3.x with pip installed. Should be documented if someone wants to use it, as pre-commit hooks in general have to be set up manually after check-out, no way to automate this even if it did not use Python.
This should be executed in terminal opened inside the cloned repo folder to install and start using it (is one time, auto-updated after):
pip install pre-commit && pre-commit install
NOTE: Review by commit
vendor
folder from all pre-commit hook stages and reverts changes that were done by second commit in vendor