Make Container
a valid ERC721 and ERC1155 receiver
#24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As we want our
Container.sol
contract to act as a true vault for users, we should allow anyone to also depositERC-721
orERC-1155
tokens, apart fromERC-20
tokens and native ETH.Changelog
This PR adds new functionalities as follows:
onERC721Received
hook required for any contract to beIERC721Receiver
compliant;onERC1155Received
andonERC1155BatchReceived
hooks required for any contract to beIERC1155Receiver
compliant;withdrawERC721
method to allow ERC-721 token withdrawal by theContainer
owner;withdrawERC1155
method to allow single and batch ERC-1155 token(s) withdrawal by theContainer
owner;Other unrelated add-ons:
fallback
method on theContainer.sol
contract to emitNativeReceived
event when ETH is sent to the contract with data or a function is called that doesn't exist in the contract;task: none