Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge staging into main #44

Open
wants to merge 50 commits into
base: main
Choose a base branch
from
Open

Merge staging into main #44

wants to merge 50 commits into from

Conversation

gabrielstoica
Copy link
Collaborator

@gabrielstoica gabrielstoica commented Jan 15, 2025 •
edited
Loading

Breaking changes:

  • Implemented WerkSubdomainRegistrar module to allow Space owners to issue werk.eth ENS subdomains;

Other changes:

  • Replaced openzeppelin-foundry-upgrades lib dependency with the according npm package;
  • Fixed stack too deep error due to enabled optimizer (ref);
  • Updated existing and added more tests;
  • Added more Makefile shortcuts;

gabrielstoica and others added 30 commits January 6, 2025 16:28
@gabrielstoica
perf: represent native token followin the ERC-7528 standard
50c0125
@gabrielstoica
test: update tests to adhere to the ERC-7528 standard
eb28d93
@gabrielstoica
ci: run 'test.yml' workflow on staging PR
73ca815
@gabrielstoica
Merge pull request #38 from xWerk/perf/erc7528-native-token
b86869a 
Represent native token following the ERC-7528 standard
@gabrielstoica
build: install '@ensdomains/ens-contracts' lib
4dcc2c0
@gabrielstoica
feat: add 'ForeverSubdomainRegistrar.sol' base implementation
45462c8
@gabrielstoica
Merge branch 'staging' into feat/ens-domains
95fc168
@gabrielstoica
feat(ens-domains): add 'FixedSubdomainPricer', allow ETH registration…
e7ebbfb 
… fee and exclude auth issuer from payment
@gabrielstoica
test: add fork tests for 'ForeverSubdomainRegistrar'
6cd5e3c
@gabrielstoica
refactor: rename 'ForeverSubdomainRegistrar' to 'WerkSubdomainRegistr…
3b72bc0 
…ar' and create dedicated interfaces folder
@gabrielstoica
build: install '@namestonehq/durin' lib
0fd7730
@gabrielstoica
build: downgrade 'Space.sol' and 'ISpace.sol' to solidity '^0.8.20'
4cf165e
@gabrielstoica
feat: add 'L2SubdomainRegistrar' implementation
8b65de7
@gabrielstoica
feat: add deterministic deployment script for 'L2SubdomainRegistrar'
a1e297f
@gabrielstoica
build: re-install 'openzeppelin-foundry-upgrades' with bun
b3765bb
@gabrielstoica
refactor: '@openzeppelin-foundry-upgrades' related paths in scripts
4f29351
@gabrielstoica
build: install '@openzeppelin/foundry-upgrades' from npm library and …
0a1c47c 
…add missing deps
@gabrielstoica
Merge pull request #40 from xWerk/build/openzeppelin-foundry-upgrades
4f45bc7 
Install `openzeppelin-foundry-upgrades` with bun
@gabrielstoica
docs: add installation guide
35a1f81
@gabrielstoica
Merge pull request #41 from xWerk/docs/update-readme
90d90fd 
docs: add installation guide
@gabrielstoica
build: fix stack too deep due to enabled optimizer
0d74648
@gabrielstoica
Merge pull request #42 from xWerk/fix/build-optimizer
4adbc8a 
build: fix stack too deep due to enabled optimizer
@gabrielstoica
Merge branch 'staging' into feat/ens-domains
a2e5341
@gabrielstoica
test: remove 'WerkSubdomainRegistrar' fork test
9e73a17
@gabrielstoica
build: bump 'Space' solidity version back to '^0.8.26'
d33781f
@gabrielstoica
feat: import NameStone's 'L2Registry', add 'Ownable' and 'onlySpace' …
b2abec2 
…modifier to 'L2SubdomainRegistrar.sol
@gabrielstoica
feat: add pricing mechanism to 'L2SubdomainRegistrar'
5564ad1
@gabrielstoica
fix: update deployment script for 'L2SubdomaiRegistrar'
47c298c
@gabrielstoica
chore: remove 'NameWrapper' based registrar
b697b94
@gabrielstoica
refactor: rename 'L2Registry' and 'L2Registrar' and update docs
832e9a8
gabrielstoica and others added 11 commits January 15, 2025 10:26
@gabrielstoica
feat: emit 'SubdomainReserved' on 'reserve' call and use 'msg.sender'…
d1934aa 
… as reservation owner
@gabrielstoica
test(ens-domains): add integration test for 'reserve' method
6b26662
@gabrielstoica
refactor(ens-domains): remove price mechanism from 'WerkSubdomainRegi…
ce91cf5 
…strar'
@gabrielstoica
refactor(ens-domains): remove 'owner' input from 'register' method an…
ba06d09 
…d improve docs
@gabrielstoica
test(ens-domains): add integration test for 'register' method
45fda53
@gabrielstoica
build: remove 'durin' lib
6376523
@gabrielstoica
feat: add ENS subdomain related scripts
638c260
@gabrielstoica
build: add Makefile deployment shortcuts and deploy L2 ENS subdomain …
9fe29d3 
…core
@gabrielstoica
Merge pull request #39 from xWerk/feat/ens-domains
3fb1751 
Issue ENS domains to Spaces
@gabrielstoica
docs: update README
21fd126
@gabrielstoica
Merge pull request #43 from xWerk/docs/reference-ens-docs
a5641bc 
docs: update README
V1d0r
V1d0r approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@V1d0r V1d0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having the sub domain registrar allows control over the domains and spaces deployed on L2 chains. We will need to think more on the L1 to L2 resolution and if it will be a problem for Werk users.

gabrielstoica and others added 9 commits January 24, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@V1d0r V1d0r V1d0r approved these changes

Assignees

@V1d0r V1d0r

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrielstoica @V1d0r