Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit in-fly of tablet deletions #13993

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

vporyadke
Copy link
Collaborator

Changelog entry

Limit number of simultaneous tablet deletions to prevent a deletion of a massive table from causing OOM-failures

Changelog category

  • Improvement

Additional information

...

Copy link

github-actions bot commented Jan 29, 2025

2025-01-29 15:55:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0d0bee6 has started.
2025-01-29 15:57:20 UTC Artifacts will be uploaded here
2025-01-29 16:00:18 UTC ya make is running...
🟡 2025-01-29 21:16:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18814 17457 0 32 1198 127

2025-01-29 21:18:29 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-29 21:30:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
231 (only retried tests) 107 0 2 1 121

2025-01-29 21:31:00 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-01-29 21:42:36 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
178 (only retried tests) 58 0 2 0 118

🟢 2025-01-29 21:42:43 UTC Build successful.
🟢 2025-01-29 21:43:06 UTC ydbd size 2.1 GiB changed* by +26.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1ce4d3d merge: 0d0bee6 diff diff %
ydbd size 2 226 168 888 Bytes 2 226 196 112 Bytes +26.6 KiB +0.001%
ydbd stripped size 470 598 064 Bytes 470 602 864 Bytes +4.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 29, 2025

2025-01-29 16:04:41 UTC Pre-commit check linux-x86_64-release-asan for 0d0bee6 has started.
2025-01-29 16:08:28 UTC Artifacts will be uploaded here
2025-01-29 16:11:26 UTC ya make is running...
🟡 2025-01-29 17:11:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11326 11233 0 32 24 37

2025-01-29 17:13:48 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-29 17:25:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
136 (only retried tests) 101 0 3 2 30

2025-01-29 17:26:11 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-29 17:37:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59 (only retried tests) 25 0 2 2 30

🟢 2025-01-29 17:38:09 UTC Build successful.
🟢 2025-01-29 17:38:37 UTC ydbd size 3.6 GiB changed* by +41.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1ce4d3d merge: 0d0bee6 diff diff %
ydbd size 3 868 601 992 Bytes 3 868 644 224 Bytes +41.2 KiB +0.001%
ydbd stripped size 1 352 693 008 Bytes 1 352 708 176 Bytes +14.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 30, 2025

2025-01-30 09:49:38 UTC Pre-commit check linux-x86_64-release-asan for edef69d has started.
2025-01-30 09:49:42 UTC Artifacts will be uploaded here
2025-01-30 09:52:45 UTC ya make is running...
🟡 2025-01-30 10:58:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11335 11257 0 32 10 36

2025-01-30 10:59:27 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-30 11:12:06 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
116 (only retried tests) 82 0 0 3 31

🟢 2025-01-30 11:12:13 UTC Build successful.
🟢 2025-01-30 11:12:40 UTC ydbd size 3.6 GiB changed* by +15.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ce7359a merge: edef69d diff diff %
ydbd size 3 868 856 784 Bytes 3 868 872 824 Bytes +15.7 KiB +0.000%
ydbd stripped size 1 352 725 712 Bytes 1 352 727 632 Bytes +1.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 30, 2025

2025-01-30 09:50:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for edef69d has started.
2025-01-30 09:50:31 UTC Artifacts will be uploaded here
2025-01-30 09:53:21 UTC ya make is running...
🟡 2025-01-30 10:40:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18824 17479 0 5 1208 132

2025-01-30 10:42:03 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-30 10:57:50 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
229 (only retried tests) 106 0 0 1 122

🟢 2025-01-30 10:57:57 UTC Build successful.
🟢 2025-01-30 10:58:18 UTC ydbd size 2.1 GiB changed* by +10.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ce7359a merge: edef69d diff diff %
ydbd size 2 226 286 072 Bytes 2 226 296 784 Bytes +10.5 KiB +0.000%
ydbd stripped size 470 617 680 Bytes 470 616 912 Bytes -768 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vporyadke vporyadke requested a review from CyberROFL January 30, 2025 16:12
@vporyadke vporyadke merged commit 43d4c47 into ydb-platform:main Jan 30, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempting to delete tablets with massive channel history leads to oom
2 participants