Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata (hc) cache for 24-4 #13994

Open
wants to merge 4 commits into
base: prestable-24-4
Choose a base branch
from

Conversation

vporyadke
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

Copy link

github-actions bot commented Jan 29, 2025

2025-01-29 15:59:33 UTC Pre-commit check for e41c5d9 has started.
2025-01-29 16:03:32 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-01-29 17:10:37 UTC Build successful.
2025-01-29 17:12:03 UTC Tests are running...
🔴 2025-01-29 19:18:28 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40422 35142 0 21 5219 40

Copy link

github-actions bot commented Jan 29, 2025

2025-01-29 16:06:22 UTC Pre-commit check for e41c5d9 has started.
2025-01-29 16:09:25 UTC Build linux-x86_64-release-asan is running...
🟢 2025-01-29 16:53:07 UTC Build successful.
2025-01-29 16:53:55 UTC Tests are running...
🔴 2025-01-29 20:05:27 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11835 11745 0 25 26 39

@@ -73,13 +73,13 @@ const TStored* TCompatibilityInfo::GetDefault(TComponentId componentId) const {
// obsolete version control
TMaybe<NActors::TInterconnectProxyCommon::TVersionInfo> VERSION = NActors::TInterconnectProxyCommon::TVersionInfo{
// version of this binary
"stable-24-3",
"stable-24-4",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут лишние коммиты попали , сделай пожалуйста pull актуальной ветки prestable-24-4

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(эта правка уже в ветке есть)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Точнее в ветке prestable-24-4 я удалил один коммит (типа неделю назад), не совсем понял как так получилось что в локальной копии у тебя он был

Предлагаю сделать новый ПР черипикнув твой коммит который ты хочешь влить

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я же уже создал новый, его и в тикет клал, и тебя в ревьюеры ставил. Как получилось, что ты в этом, Ильназ переслал что ли?)

Ну да, у меня локально была старая ветка, я не так часто делаю пулл не-мейна

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants