Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add custom errors for TFHE #658

Merged
merged 2 commits into from
Dec 19, 2024
Merged

refactor: add custom errors for TFHE #658

merged 2 commits into from
Dec 19, 2024

Conversation

PacificYield
Copy link
Contributor

@PacificYield PacificYield commented Dec 16, 2024

This PR replaces require statements for custom errors in the TFHE.sol library.

@PacificYield PacificYield self-assigned this Dec 16, 2024
@PacificYield PacificYield marked this pull request as ready for review December 16, 2024 16:18
@@ -265,6 +265,16 @@ ${commonSolLib()}
* that interact with TFHE.
*/
library TFHE {

/// @notice Returned if the input's length is strictly greater than 64 bytes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you dont need to put "strictly" in English fyi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted!

@PacificYield PacificYield merged commit 269931d into main Dec 19, 2024
4 checks passed
@PacificYield PacificYield deleted the custom-errors-tfhe branch December 19, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants