New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gpu): use struct to pass radix data in the ffi #1994

Merged

agnesLeroy merged 1 commit into main from al/pass_struct_accross_rust_c_ffi

Jan 24, 2025

Contributor

agnesLeroy commented Jan 20, 2025

closes: please link all relevant issues

PR content/description

Check-list:

Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
Relevant issues are marked as resolved/closed, related issues are linked in the description
Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

cla-bot bot added the cla-signed label

agnesLeroy requested review from pdroalves, bbarbakadze and guillermo-oyarzun

January 20, 2025 08:50

agnesLeroy commented

View reviewed changes

backends/tfhe-cuda-backend/cuda/include/integer/radix_ciphertext.h Outdated Show resolved Hide resolved

agnesLeroy commented

View reviewed changes

backends/tfhe-cuda-backend/cuda/src/integer/abs.cuh Show resolved Hide resolved

agnesLeroy force-pushed the al/pass_struct_accross_rust_c_ffi branch 2 times, most recently from 732192e to c3fc1cb Compare

January 20, 2025 09:04

guillermo-oyarzun reviewed

View reviewed changes

backends/tfhe-cuda-backend/cuda/include/integer/radix_ciphertext.h Outdated Show resolved Hide resolved

backends/tfhe-cuda-backend/cuda/include/integer/integer.h Show resolved Hide resolved

backends/tfhe-cuda-backend/cuda/include/linear_algebra.h Show resolved Hide resolved

backends/tfhe-cuda-backend/cuda/src/device.cu Show resolved Hide resolved

guillermo-oyarzun reviewed

View reviewed changes

tfhe/src/integer/gpu/server_key/radix/cmux.rs Outdated Show resolved Hide resolved

tfhe/src/integer/gpu/mod.rs Show resolved Hide resolved

agnesLeroy commented

View reviewed changes

tfhe/src/integer/gpu/mod.rs Outdated Show resolved Hide resolved

agnesLeroy commented

View reviewed changes

tfhe/src/integer/gpu/mod.rs Outdated Show resolved Hide resolved

agnesLeroy commented

View reviewed changes

backends/tfhe-cuda-backend/cuda/src/integer/abs.cuh Show resolved Hide resolved

agnesLeroy force-pushed the al/pass_struct_accross_rust_c_ffi branch from c3fc1cb to 84d93e0 Compare

January 20, 2025 13:45

agnesLeroy changed the title ~~Start new struct to pass data around~~ chore(gpu): use struct to pass radix data in the ffi

agnesLeroy marked this pull request as ready for review

January 20, 2025 15:49

agnesLeroy force-pushed the al/pass_struct_accross_rust_c_ffi branch from 84d93e0 to 01a1ff1 Compare

January 20, 2025 16:00

agnesLeroy commented

View reviewed changes

tfhe/src/integer/server_key/radix_parallel/tests_long_run/mod.rs Outdated Show resolved Hide resolved

agnesLeroy marked this pull request as draft

January 20, 2025 16:17

agnesLeroy force-pushed the al/pass_struct_accross_rust_c_ffi branch 3 times, most recently from 5045542 to 83767cd Compare

January 21, 2025 10:46

agnesLeroy marked this pull request as ready for review

January 21, 2025 10:46

agnesLeroy requested a review from guillermo-oyarzun

January 21, 2025 10:46

agnesLeroy force-pushed the al/pass_struct_accross_rust_c_ffi branch 2 times, most recently from 75f7748 to a7bb6b2 Compare

January 21, 2025 11:28

guillermo-oyarzun reviewed

View reviewed changes

backends/tfhe-cuda-backend/cuda/include/integer/integer_utilities.h Outdated Show resolved Hide resolved

guillermo-oyarzun reviewed

View reviewed changes

backends/tfhe-cuda-backend/cuda/include/integer/integer.h Show resolved Hide resolved

agnesLeroy force-pushed the al/pass_struct_accross_rust_c_ffi branch 2 times, most recently from 94be77b to f0ebcb4 Compare

January 23, 2025 16:49


          chore(gpu): start using a struct to pass data across rust/c++

26ff645

agnesLeroy force-pushed the al/pass_struct_accross_rust_c_ffi branch from f0ebcb4 to 26ff645 Compare

January 24, 2025 08:16

guillermo-oyarzun approved these changes

View reviewed changes

zama-bot added the approved label

agnesLeroy merged commit 7a241aa into main

146 checks passed

agnesLeroy deleted the al/pass_struct_accross_rust_c_ffi branch

January 24, 2025 14:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cla-signed