Al/refactor lut #2001
Merged
Al/refactor lut #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnesLeroy
force-pushed
the
al/refactor_lut
branch
from
703b010 to
057e81b
Compare
agnesLeroy
requested review from
bbarbakadze,
pdroalves and
guillermo-oyarzun
and removed request for
bbarbakadze
agnesLeroy
force-pushed
the
al/refactor_lut
branch
2 times, most recently
from
c5896c6 to
bc5e468
Compare
backends/tfhe-cuda-backend/cuda/include/integer/integer_utilities.h
Outdated
Show resolved
Hide resolved
agnesLeroy
force-pushed
the
al/refactor_lut
branch
from
bc5e468 to
f27212b
Compare
backends/tfhe-cuda-backend/cuda/include/integer/integer_utilities.h
Outdated
Show resolved
Hide resolved
agnesLeroy
force-pushed
the
al/refactor_lut
branch
from
f27212b to
ef4e649
Compare
guillermo-oyarzun
approved these changes
Jan 27, 2025
|
Maybe it would be good to launch the long tests on this PR before merging it, mainly to test the many combinations of the luts |
|
I'll do a quick run locally with less ops. Since only the C++ side is modified, this does not affect the computation of noise level/degree on the Rust side yet. Next PR should do that. |
ahh ok, then maybe it is not needed, if nothing is using this yet, probably we won't see anything with the tests anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: please link all relevant issues
PR content/description
This PR introduces degree / max degree data in the int_radix_lut structure, to prepare for noise tracking in apply_uni/bivariate_lookup_table.
I chose to track max_degree as well because for the many lut case it depends on the number of luts applied.
Check-list: