refactor!: Add invariant to GpuIndex #2006
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmontaigu
force-pushed
the
tm/gpu-index-invariant
branch
4 times, most recently
from
2481ee9 to
b89393d
Compare
This commit does 2 things: * It adds to GpuIndex the invariant that the index corresponds to a valid GPU, to do so, the inner u32 is made private and new/try_new method are now used to construct a GpuIndex these methods checks that the index is valid * It makes GpuIndex transparent, allowing to safely cast a *const GpuIndex to *const u32, this is to save same copies made to transform Vec<GpuIndex> to Vec<u32> that was used to get a *const u32 BREAKING CHANGES: GpuIndex(some_value) is no longer valid and GpuIndex::new(some_value) / GpuIndex::try_new(some_value) has to be used
tmontaigu
force-pushed
the
tm/gpu-index-invariant
branch
from
b89393d to
54adb40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does 2 things:
BREAKING CHANGES: GpuIndex(some_value) is no longer valid and GpuIndex::new(some_value) / GpuIndex::try_new(some_value) has to be used