Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gpu): track noise level/degree in apply lut #2007

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

agnesLeroy
Copy link
Contributor

@agnesLeroy agnesLeroy commented Jan 27, 2025

closes: please link all relevant issues

PR content/description

This PR adds the tracking of noise/degree in apply_univariate_lut. The Rust entry point now updates noise level/degree and we also have this tracking on the C++ side, and can start using it for refactored entry points.

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Jan 27, 2025
@agnesLeroy agnesLeroy force-pushed the al/refactor_apply_lut branch 3 times, most recently from 6674192 to e0e395e Compare January 28, 2025 17:56
@agnesLeroy agnesLeroy marked this pull request as ready for review January 28, 2025 17:58
@agnesLeroy agnesLeroy marked this pull request as draft January 29, 2025 10:20
@agnesLeroy agnesLeroy force-pushed the al/refactor_apply_lut branch from e0e395e to 9ceb912 Compare January 29, 2025 11:47
@agnesLeroy agnesLeroy marked this pull request as ready for review January 29, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants