Merge pull request #3595 from thc202/selenium/stats-launch

selenium: add simple stats
zaproxy · Feb 17, 2022 · de7afd7 · de7afd7
2 parents 4471601 + 19c460d
commit de7afd7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/addOns/selenium/CHANGELOG.md b/addOns/selenium/CHANGELOG.md
@@ -5,6 +5,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## Unreleased
+### Added
+- Statistics, number of browsers launched.
+
 ### Fixed
 - Quit all browsers when ZAP shuts down ([Issue #6643](https://github.com/zaproxy/zaproxy/issues/6643)).
 

diff --git a/addOns/selenium/src/main/java/org/zaproxy/zap/extension/selenium/ExtensionSelenium.java b/addOns/selenium/src/main/java/org/zaproxy/zap/extension/selenium/ExtensionSelenium.java
@@ -65,6 +65,7 @@
 import org.zaproxy.zap.extension.script.ScriptType;
 import org.zaproxy.zap.extension.script.ScriptWrapper;
 import org.zaproxy.zap.extension.selenium.internal.BuiltInSingleWebDriverProvider;
+import org.zaproxy.zap.utils.Stats;
 
 /**
  * An {@code Extension} that provides {@code WebDriver} implementations for several {@code
@@ -854,6 +855,7 @@ public static WebDriver getWebDriver(
                 getWebDriverImpl(
                         requester, browser, proxyAddress, proxyPort, c -> {}, enableExtensions);
         webDrivers.add(wd);
+        updateStats(browser);
         return wd;
     }
 
@@ -878,9 +880,14 @@ public static WebDriver getWebDriver(
         WebDriver wd =
                 getWebDriverImpl(-1, browser, proxyAddress, proxyPort, consumer, enableExtensions);
         webDrivers.add(wd);
+        updateStats(browser);
         return wd;
     }
 
+    private static void updateStats(Browser browser) {
+        Stats.incCounter("stats.selenium.launch." + browser.getId());
+    }
+
     private static void setCommonOptions(
             MutableCapabilities capabilities, String proxyAddress, int proxyPort) {
         capabilities.setCapability(CapabilityType.ACCEPT_SSL_CERTS, true);