-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Sonobe integration #14
Open
pmikolajczyk41
wants to merge
148
commits into
master
Choose a base branch
from
sonobe-integration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmikolajczyk41
force-pushed
the
sonobe-integration
branch
from
December 6, 2024 11:40
34467f0
to
ed6312c
Compare
pmikolajczyk41
force-pushed
the
sonobe-integration
branch
from
December 6, 2024 12:38
ed6312c
to
29b7c47
Compare
Just pure beauty of quality work 😍 Note The only reason that this isn't merged yet is the Artifacts evaluation process from PETS 2025 Conference.
|
lovely-necromancer
added
enhancement
New feature or request
dependencies
Pull requests that update a dependency file
awesome
Impressive effort
labels
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awesome
Impressive effort
dependencies
Pull requests that update a dependency file
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step of the VIMz <-> Sonobe integration.
Changes
step_in
->ivc_input
,step_out
->ivc_output
and a small input rework (singlesignal input external_inputs
that is later split intorow_orig
androw_tran
)build_circuits.sh
fails after first error.Cargo.toml
a bit.Running
Prerequisite: run
./build_circuits.sh
in thecircuits
directory.Go to the
nova
directory and run:make grayscale # or LIGHT_TEST=yes make grayscale
The first command will run full pipeline. The second one omits large part of the decider circuit and thus reduces significantly running time (decider parameters and proof generation times drop by orders of magnitude).
Current results
Currently, performance drops awfully. Running 5 iterations (
make brightness
) on AWS EC2 c6a.4xlarge (16 CPU, 32GB RAM) generates output:Using better machine (c6a.8xlarge, with doubled resources), generates output:
Both runs require ~22GB of RAM (both for decider operations (params and proof) as well as for the folding steps).
Notes
Currently, only grayscale, blur and brightness transformation are supported.