Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIP-8056 disable volume_mode="ReadWriteMany" test #282

Merged
merged 1 commit into from
Feb 1, 2024
Merged

AIP-8056 disable volume_mode="ReadWriteMany" test #282

merged 1 commit into from
Feb 1, 2024

Conversation

talebzeghmi
Copy link
Collaborator

No description provided.

cloudw
cloudw approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@cloudw cloudw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you please add a short description around why this is needed?

@talebzeghmi
Copy link
Collaborator Author

LGTM. Could you please add a short description around why this is needed?

The bug AIP-8056 contains more.
I hope we course a path in grooming this Friday, either we:

  • remove this unused feature
  • spend time to fix this unit test (or make it more robust)
  • keep this unused feature, but disabling this unit test

@talebzeghmi talebzeghmi merged commit 90630f1 into feature/aip Feb 1, 2024
4 checks passed
@talebzeghmi talebzeghmi deleted the tz/AIP-8056-disable-rwmany-test branch February 1, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaron-arellano aaron-arellano aaron-arellano approved these changes

@cloudw cloudw cloudw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@talebzeghmi @cloudw @aaron-arellano