Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork offering results to stream #1411

Closed
wants to merge 3 commits into from
Closed

Conversation

svroonland
Copy link
Collaborator

Performance experiment

@erikvanoosten
Copy link
Collaborator

That simple 🙂
BTW, the benchmarks timed out. Probably because we need to shift this work to another executor (e.g. the default one). If we do a fork from the single thread executor, the task will need to wait until the runloop yields.

@erikvanoosten
Copy link
Collaborator

I hope I fixed the benchmarks.

Note: this must never be merged. We need to guarantee that records are offered in order. This is a nice experiment though!

@erikvanoosten
Copy link
Collaborator

afbeelding Doesn't speed it up at all ... 😞

It is running on the runloops single thread executor anyway!
@erikvanoosten
Copy link
Collaborator

erikvanoosten commented Dec 15, 2024

@svroonland As it doesn't seem to work, shall we close this issue?

@svroonland svroonland closed this Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants