-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document transactions #1432
base: master
Are you sure you want to change the base?
Document transactions #1432
Conversation
cd107ab
to
8233bc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice and clear documentation! A few remarks
Now we can create layers for the `ProducerSettings` and the `TransactionalProducer`. | ||
Note that the producer connects (and must connect) to the same brokers as the consumer. | ||
|
||
DEVELOPER NOTE: here we assume that we no longer have `TransactionalProducerSettings`. TODO: check this assertion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to evaluate if we still need the user to provide transactionalId
. If not, we can use ProducerSettings
, if it is needed, we continue to need TransactionalProducerSettings
.
Document the transactional producer introduced in #1434.
1cb2065
to
6eb76b0
Compare
Document the transactional producer introduced in #1434.
This is a DRAFT PR because #1434 is not done yet.