Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document transactions #1432

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Document transactions #1432

wants to merge 1 commit into from

Conversation

erikvanoosten
Copy link
Collaborator

@erikvanoosten erikvanoosten commented Jan 9, 2025

Document the transactional producer introduced in #1434.

This is a DRAFT PR because #1434 is not done yet.

@erikvanoosten erikvanoosten added this to the 3.0.0 milestone Jan 9, 2025
Copy link
Collaborator

@svroonland svroonland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice and clear documentation! A few remarks

docs/transactions.md Show resolved Hide resolved
docs/transactions.md Outdated Show resolved Hide resolved
docs/transactions.md Outdated Show resolved Hide resolved
docs/transactions.md Outdated Show resolved Hide resolved
Now we can create layers for the `ProducerSettings` and the `TransactionalProducer`.
Note that the producer connects (and must connect) to the same brokers as the consumer.

DEVELOPER NOTE: here we assume that we no longer have `TransactionalProducerSettings`. TODO: check this assertion
Copy link
Collaborator Author

@erikvanoosten erikvanoosten Jan 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to evaluate if we still need the user to provide transactionalId. If not, we can use ProducerSettings, if it is needed, we continue to need TransactionalProducerSettings.

Document the transactional producer introduced in #1434.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants