Harmonize consumer diagnostics handling #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikvanoosten
changed the title
erikvanoosten
changed the title
Some of the different `Consumer` builders were not using `ConcurrentDiagnostics` yet to protect the consumer from slow diagnostics implementations. This is fixed. Since `ConcurrentDiagnostics` injects the final event, the `Consumer` builders do not need to do this.
erikvanoosten
force-pushed
the
concurrent-diagnostics
branch
from
2c158bb to
7d60a26
Compare
svroonland
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the different
Consumerbuilders were not usingConcurrentDiagnosticsyet to protect the consumer from slow diagnostics implementations. This is fixed.Since
ConcurrentDiagnosticsinjects the final event, theConsumerbuilders do not need to do this.