[REFACTOR] Split up exec_pipeline() for readability
#354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itislu
commented
Jul 4, 2024
| @@ -46,35 +50,44 @@ void fork_pipeline(t_sh *shell, t_list_d **cmd_table_node) | |||
| } | |||
| } | |||
|
|
|||
| static void exec_pipeline(t_sh *shell, t_list_d **cmd_table_node) | |||
| static void iter_pipeline(t_sh *shell, t_list_d **cmd_table_node) | |||
There was a problem hiding this comment.
Is the new name of this function okay for you?
itislu
force-pushed
the
refactor-pipeline-readability
branch
3 times, most recently
from
73daa62 to
90e2af8
Compare
itislu
force-pushed
the
refactor-pipeline-readability
branch
2 times, most recently
from
e539ab2 to
c093097
Compare
itislu
force-pushed
the
refactor-pipeline-readability
branch
from
c093097 to
8aa7b79
Compare
itislu
force-pushed
the
refactor-pipeline-readability
branch
from
8aa7b79 to
2a824c4
Compare
The function was very dense and we resorted to bad practices like the comma operator to keep the function length within 25 lines for Norminette.
itislu
force-pushed
the
refactor-pipeline-readability
branch
from
2a824c4 to
bc12151
Compare
LeaYeh
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function was very dense and we resorted to bad practices like the comma operator to keep the function length within 25 lines for Norminette.
elseblock ofexec_pipeline()into separateexec_cmd_table()function and rename the original function toiter_pipeline().while (check cmd_table_type)loop check towhile (true)+if (check cmd_table_type)+break.