Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Parser - Generate command table list to replace AST #50

Merged
merged 12 commits into from
Dec 30, 2023
Merged

[FEAT] Parser - Generate command table list to replace AST #50

merged 12 commits into from
Dec 30, 2023

Conversation

LeaYeh
Copy link
Owner

@LeaYeh LeaYeh commented Dec 29, 2023 •
edited
Loading

At this state the command table is not compelete yet,
during the execution phase, the executor will finish the command table

  • Parent process need to...
    • handle heredoc
    • handle redirection
    • handle expansion
    • open red_out file then assign the fd back to the cmd table

@LeaYeh
chore: Re-order the function define
c5afaf3
@LeaYeh
chore: Remove unnecessory header include
4ef372c
@LeaYeh
refact: Parse from dup token list
37dc22b
@LeaYeh
chore: Rename core file name of parser module
d6be95e
@LeaYeh
chore: Change file name
5f84f69
@LeaYeh
feat: Generate command table list and debug utils
a30a178 
At this state the command table is not compelete yet,
during the execution phase, the executor will finish the command table
* Parent process need to...
    - handle heredoc
    - handle redirection
    - handle expansion
    - open red_out file then assign the fd back to the cmd table
@LeaYeh LeaYeh added the feature New feature of the project label Dec 29, 2023
@LeaYeh LeaYeh added this to the Parser milestone Dec 29, 2023
@itislu itislu mentioned this pull request Dec 29, 2023
Closed
@itislu
Copy link
Collaborator

itislu commented Dec 30, 2023

I will review it as soon as I'm on campus again later today.

@itislu itislu self-assigned this Dec 30, 2023
itislu
itislu requested changes Dec 30, 2023
View reviewed changes
include/defines.h Show resolved Hide resolved
source/utils/token_utils.c Outdated Show resolved Hide resolved
source/frontend/parser/parser.c Show resolved Hide resolved
source/utils/cmd_table_utils.c Outdated Show resolved Hide resolved
source/utils/io_redirect_utils.c Outdated Show resolved Hide resolved
itislu
itislu requested changes Dec 30, 2023
View reviewed changes
source/utils/cmd_table_utils.c Outdated Show resolved Hide resolved
source/frontend/parser/parser.c Outdated Show resolved Hide resolved
itislu
itislu requested changes Dec 30, 2023
View reviewed changes
source/frontend/parser/cmd_table_symbol.c Show resolved Hide resolved
source/frontend/parser/cmd_table_symbol.c Outdated Show resolved Hide resolved
source/utils/io_redirect_utils.c Outdated Show resolved Hide resolved
source/frontend/parser/cmd_table_word.c Outdated Show resolved Hide resolved
@itislu itislu force-pushed the feat-parser-cmdtable branch from be73518 to f5e7aec Compare December 30, 2023 15:42
@itislu
Copy link
Collaborator

itislu commented Dec 30, 2023

Now I'm done. Really great job, Lea!

@LeaYeh
Copy link
Owner Author

LeaYeh commented Dec 30, 2023

Noooooooo why you rebase it......

@itislu
Copy link
Collaborator

itislu commented Dec 30, 2023 •
edited
Loading

I did nooooooooott. Just fixed a typo in my last commit message

@itislu itislu merged commit bbfa1a4 into main Dec 30, 2023
1 check passed
@LeaYeh LeaYeh deleted the feat-parser-cmdtable branch December 30, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itislu itislu itislu approved these changes

Assignees

@itislu itislu

Labels
feature New feature of the project
Projects
None yet
Milestone
Parser
Development

Successfully merging this pull request may close these issues.
2 participants
@LeaYeh @itislu