-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logic for running offline IODA tools. #600
base: rrfs-mpas-jedi
Are you sure you want to change the base?
Add logic for running offline IODA tools. #600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but will wait to hear from others before merging...
scripts/exrrfs_ioda_bufr.sh
Outdated
${cpreq} ${HOMErrfs}/sorc/RDASApp/rrfs-test/IODA/offline_add_var_to_ioda.py . | ||
ioda_files=$(ls ioda*nc) | ||
for ioda_file in ${ioda_files[@]}; do | ||
python offline_add_var_to_ioda.py -o ${ioda_file} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think NCO wants the script (including *.py) to run from the command line directly without the leading "python".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, has the Python environment been correctly loaded for this tool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guoqing-noaa, thanks for the comments. The tool already had #!/usr/bin/env python
at the top. Its just habit to run it with python
anyway. I just removed it in my most recent commit and it still works. As for the python environment it seems everything that is needed is already loaded so I didn't have to load anything else.
@delippi Did you test within the leading python to make sure it all still works? If so, think we can merge it. |
@MatthewPyle-NOAA hold off on merging though. There are some dependencies. Edit: The dependencies are documented in the initial comment. Please don't merge until those are satisfied, otherwise the python tool won't be available. I need some people to review that NOAA-EMC/RDASApp#259. |
I also just noticed that this |
scripts/exrrfs_ioda_bufr.sh
Outdated
${cpreq} ${HOMErrfs}/sorc/RDASApp/rrfs-test/IODA/offline_add_var_to_ioda.py . | ||
ioda_files=$(ls ioda*nc) | ||
for ioda_file in ${ioda_files[@]}; do | ||
offline_add_var_to_ioda.py -o ${ioda_file} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for another comment, could you add ./
before offline_add_var_to_ioda.py
?
Not all environments put the current directory in the $PATH variable.
(for example, our Jet role account cron jobs set $PATH to empty)
@delippi Thanks for noticing this! Yes, we will need to update the bufr2ioda yaml files. For all PARM files, rrfs-workflow will be self-contained. That means, RDASApp manages its parm/test files while rrfs-workflow adapts a given version from RDASApp. This adheres to the NCO standard generating PARM files on the fly from the |
I would suggest we hold this PR until the discussion in NOAA-EMC/RDASApp#259 is resolved. |
DESCRIPTION OF CHANGES:
exrrfs_ioda_bufr.sh
to run an offline tool to process IODA files. The offline tool addsMetaData/longitude_latitude_pressure
to the IODA file which is used as the group category for duplicate checking based on RDASApp#259TESTS CONDUCTED:
Tested on Hera conus 12km retro runs.
ISSUE:
Dependencies: