bugfix: GlobalTransactionScanner.afterPropertiesSet need do scanner check #7124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
reviewed
Jan 21, 2025
spring/src/main/java/org/apache/seata/spring/annotation/GlobalTransactionScanner.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7124 +/- ##
============================================
+ Coverage 53.08% 53.17% +0.09%
- Complexity 6795 6810 +15
============================================
Files 1136 1137 +1
Lines 40341 40368 +27
Branches 4723 4727 +4
============================================
+ Hits 21416 21467 +51
+ Misses 16885 16854 -31
- Partials 2040 2047 +7
|
funky-eyes
approved these changes
Jan 21, 2025
funky-eyes
added
type: bug
added 2 commits
January 21, 2025 14:11
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
|
done |
funky-eyes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
GlobalTransactionScanner.afterPropertiesSet need do scanner check
Ⅱ. Does this pull request fix one issue?
fixes #7113
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews