Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: GlobalTransactionScanner.afterPropertiesSet need do scanner check #7124

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/en-us/2.x.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ Add changes here for all PR submitted to the 2.x branch.
- [[#7116](https://github.com/apache/incubator-seata/pull/7116)] fix prefix: seata.server.raft.ssl should not be null
- [[#7112](https://github.com/apache/incubator-seata/pull/7112)] bugfix: remove the condition that IPv6 must start with fe80
- [[#7107](https://github.com/apache/incubator-seata/pull/7107)] fix the issue of failing to parse annotations in TCC mode when the business object is a proxy object.
- [[#7124](https://github.com/apache/incubator-seata/pull/7124)] bugfix: GlobalTransactionScanner.afterPropertiesSet need do scanner check


### optimize:
Expand Down
1 change: 1 addition & 0 deletions changes/zh-cn/2.x.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
- [[#7116](https://github.com/apache/incubator-seata/pull/7116)] 修复 seata.server.raft.ssl 前缀不存在的问题
- [[#7112](https://github.com/apache/incubator-seata/pull/7112)] 校验是否IPv6网络ip取消必须以fe80开始的条件
- [[#7107](https://github.com/apache/incubator-seata/pull/7107)] 修复tcc模式下,当业务对象为代理对象时,解析注解失败问题。
- [[#7124](https://github.com/apache/incubator-seata/pull/7124)] GlobalTransactionScanner.afterPropertiesSet方法需要做扫描检查

### optimize:

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,10 @@ private boolean doCheckers(Object bean, String beanName) {
return false;
}

return doScannerCheckers(bean, beanName);
}

private boolean doScannerCheckers(Object bean, String beanName) {
funky-eyes marked this conversation as resolved.
Show resolved Hide resolved
if (!SCANNER_CHECKER_SET.isEmpty()) {
for (ScannerChecker checker : SCANNER_CHECKER_SET) {
try {
Expand All @@ -354,7 +358,6 @@ private boolean doCheckers(Object bean, String beanName) {
}
}
}

return true;
}

Expand Down Expand Up @@ -512,6 +515,9 @@ private void findBusinessBeanNamesNeededEnhancement() {
if (IGNORE_ENHANCE_CHECK_SET.contains(beanDefinition.getBeanClassName())) {
continue;
}
if (!doScannerCheckers(null, beanDefinition.getBeanClassName())) {
continue;
}
try {
// get the class by bean definition class name
Class<?> beanClass = Class.forName(beanDefinition.getBeanClassName());
Expand Down
Loading