Improve UX on dismissing the SettingsPanel
#678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonko1994
commented
Jan 14, 2025
| @@ -124,6 +126,13 @@ export class SettingsPanel extends Container<SettingsPanelConfig> { | |||
| player.on(player.exports.PlayerEvent.PlayerResized, handleResize); | |||
| } | |||
|
|
|||
| const maybeCloseSettingsPanel = (event: KeyboardEvent) => { | |||
| const action = getKeyMapForPlatform()[event.keyCode]; | |||
There was a problem hiding this comment.
I intentionally use the deprecated event.keyCode here to support other Devices that do not have an Escape button. Such as TVs or gaming consoles. The Action.BACK mapping is already covered using the keyCode.
stonko1994
changed the title
SettingsPanel
…anel # Conflicts: # src/scss/bitmovinplayer-ui.scss # src/ts/UIFactory.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the SettingsPanel only dismisses when explicitly clicking the settings button again, or after a timeout (web only). Therefore, it's tedious to close the SettingsPanel after changing a setting.
Changes
DismissClickOverlaywhich can be used to dismiss any Component when it's visible.