-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve UX on dismissing the SettingsPanel
#678
Merged
stonko1994
merged 4 commits into
feature/modern-ui-base
from
feature/dismiss-settings-panel
Jan 23, 2025
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
1ff8121
dismiss the SettingsPanel on ESC keyboard input
stonko1994 3604060
add a DismissClickOverlay component to dismiss any component on click…
stonko1994 c6a7ae3
fix outdated import
stonko1994 4a432d4
Merge branch 'feature/modern-ui-base' into feature/dismiss-settings-p…
stonko1994 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
@import '../../variables'; | ||
@import '../../mixins'; | ||
|
||
.#{$prefix}-ui-dismiss-click-overlay { | ||
@include layout-cover; | ||
@include hidden; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
import { ButtonConfig } from '../buttons/Button'; | ||
import { Component, ComponentConfig } from '../Component'; | ||
import { Container } from '../Container'; | ||
import { PlayerAPI } from 'bitmovin-player'; | ||
import { UIInstanceManager } from '../../UIManager'; | ||
|
||
export interface DismissClickOverlayConfig extends ButtonConfig { | ||
target: Component<ComponentConfig>; | ||
} | ||
|
||
export class DismissClickOverlay extends Container<DismissClickOverlayConfig> { | ||
constructor(config: DismissClickOverlayConfig) { | ||
super(config); | ||
|
||
this.config = this.mergeConfig(config, { | ||
cssClass: 'ui-dismiss-click-overlay', | ||
role: this.config.role, | ||
}, <DismissClickOverlayConfig>this.config); | ||
} | ||
|
||
configure(player: PlayerAPI, uimanager: UIInstanceManager) { | ||
super.configure(player, uimanager); | ||
|
||
this.config.target.onShow.subscribe(() => { this.show(); }); | ||
this.config.target.onHide.subscribe(() => { this.hide(); }); | ||
|
||
let element = this.getDomElement(); | ||
element.on('click', () => { | ||
this.config.target.hide(); | ||
}); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intentionally use the deprecated
event.keyCode
here to support other Devices that do not have an Escape button. Such as TVs or gaming consoles. TheAction.BACK
mapping is already covered using thekeyCode
.