Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Refine error msg for schema & index checking #39533

Merged
merged 3 commits into from
Jan 24, 2025
Merged

enhance: Refine error msg for schema & index checking #39533

merged 3 commits into from
Jan 24, 2025
+25 −23

Conversation

congqixia
Copy link
Contributor

The error message was malformated or missing some meta info, say field name. This PR recitfies some message format and add field name in error message when type param check fails.

@congqixia
enhance: Refine error msg for schema & index checking
8f48023 
The error message was malformated or missing some meta info, say field
name. This PR recitfies some message format and add field name in error
message when type param check fails.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot requested review from czs007 and sunby January 23, 2025 02:47
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. approved labels Jan 23, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 23, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 23, 2025

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 23, 2025

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.91%. Comparing base (7476eb3) to head (3174acb).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
internal/datacoord/index_service.go 50.00% 2 Missing ⚠️
internal/proxy/util.go 81.81% 2 Missing ⚠️
internal/proxy/task_index.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39533       +/-   ##
===========================================
+ Coverage   69.56%   80.91%   +11.35%     
===========================================
  Files         300     1408     +1108     
  Lines       26986   198884   +171898     
===========================================
+ Hits        18773   160932   +142159     
- Misses       8213    32249    +24036     
- Partials        0     5703     +5703
Components Coverage Δ
Client 79.51% <ø> (∅)
Core 69.56% <ø> (-0.01%) ⬇️
Go 82.82% <68.75%> (∅)
Files with missing lines Coverage Δ
internal/proxy/task_index.go 74.61% <0.00%> (ø)
internal/datacoord/index_service.go 91.65% <50.00%> (ø)
internal/proxy/util.go 89.32% <81.81%> (ø)

... and 1106 files with indirect coverage changes

@congqixia
Fix test cases
6731157 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 23, 2025

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Update milvus_client test case
3174acb 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 23, 2025

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 23, 2025
@yanliang567
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 05b6ea1 into milvus-io:master Jan 24, 2025
19 of 20 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Jan 24, 2025
@congqixia
enhance: Refine error msg for schema & index checking (milvus-io#39533)
53b3049 
The error message was malformated or missing some meta info, say field
name. This PR recitfies some message format and add field name in error
message when type param check fails.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this pull request Jan 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@sunby sunby Awaiting requested review from sunby

Assignees

@yanliang567 yanliang567

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congqixia @sre-ci-robot @yanliang567