-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Docker in the nightly testing #1033
base: main
Are you sure you want to change the base?
Conversation
Bump version of |
CMakeLists.txt
Outdated
@@ -33,6 +33,13 @@ include(CMakePackageConfigHelpers) | |||
include(GNUInstallDirs) | |||
find_package(PkgConfig) | |||
|
|||
find_package(Valgrind REQUIRED) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, we already have finding valgrind
https://github.com/oneapi-src/unified-memory-framework/blob/main/src/utils/CMakeLists.txt#L32
.github/workflows/nightly.yml
Outdated
- name: Fuzz long test | ||
working-directory: ${{github.workspace}}/build | ||
run: ctest -C ${{matrix.build_type}} --output-on-failure --verbose -L "fuzz-long" | ||
- name: Fuzz long test in Docker container |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, at the beginning you can run more simple tests (like BasicBuilds or FastBuilds). Let's say Valgrind and Fuzz tests are a little more complicated and can be added separately.
Also, you don't have to update existing jobs to use dockers, as discussed - for the starters we can add one extra job running on dockers in nightly build
sphinxcontrib_htmlhelp==2.1.0 | ||
sphinxcontrib_serializinghtml==2.0.0 | ||
sphinxcontrib_qthelp==2.0.0 | ||
pygments==2.18.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should rather not downgrade packages, rather move them up
Using docker in the nightly testing