Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Docker in the nightly testing #1033

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

Conversation

rbanka1
Copy link
Contributor

@rbanka1 rbanka1 commented Jan 13, 2025

Using docker in the nightly testing

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@lukaszstolarczuk lukaszstolarczuk changed the title Docker in the nightly testing [WIP] Docker in the nightly testing Jan 13, 2025
@KFilipek
Copy link
Contributor

 The conflict is caused by:
    The user requested sphinx==7.1.2
    breathe 4.35.0 depends on Sphinx!=5.0.0 and >=4.0
    sphinx-book-theme 1.0.1 depends on sphinx<7 and >=4

Bump version of sphinx-book-theme to the newer, or just lower version of sphinx below 7

CMakeLists.txt Outdated
@@ -33,6 +33,13 @@ include(CMakePackageConfigHelpers)
include(GNUInstallDirs)
find_package(PkgConfig)

find_package(Valgrind REQUIRED)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- name: Fuzz long test
working-directory: ${{github.workspace}}/build
run: ctest -C ${{matrix.build_type}} --output-on-failure --verbose -L "fuzz-long"
- name: Fuzz long test in Docker container
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, at the beginning you can run more simple tests (like BasicBuilds or FastBuilds). Let's say Valgrind and Fuzz tests are a little more complicated and can be added separately.

Also, you don't have to update existing jobs to use dockers, as discussed - for the starters we can add one extra job running on dockers in nightly build

sphinxcontrib_htmlhelp==2.1.0
sphinxcontrib_serializinghtml==2.0.0
sphinxcontrib_qthelp==2.0.0
pygments==2.18.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should rather not downgrade packages, rather move them up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants