[WIP] Docker in the nightly testing

.github/docker/ubuntu-20.04.Dockerfile

@@ -50,8 +50,21 @@ RUN apt-get update \
  && rm -rf /var/lib/apt/lists/* \
  && apt-get clean all
 
+# Install hwloc
+COPY .github/scripts/install_hwloc.sh /opt/umf/install_hwloc.sh
+RUN apt-get update \
+	&& apt-get install -y dos2unix libtool \
+	&& dos2unix /opt/umf/install_hwloc.sh \
+	&& bash -x /opt/umf/install_hwloc.sh \
+	&& ldconfig \
+	&& rm -f /opt/umf/install_hwloc.sh
+
+# Install valgrind
+RUN apt-get update && \
+	apt-get install -y valgrind cmake hwloc libhwloc-dev libnuma-dev libtbb-dev
+
 # Prepare a dir (accessible by anyone)
-RUN mkdir --mode 777 /opt/umf/
+RUN mkdir -p --mode 777 /opt/umf/
 
 # Additional dependencies (installed via pip)
 COPY third_party/requirements.txt /opt/umf/requirements.txt

.github/workflows/nightly.yml

@@ -2,10 +2,10 @@
 name: Nightly
 
 # This job is run at 00:00 UTC every day or on demand.
-on:
-  workflow_dispatch:
-  schedule:
-    - cron:  '0 0 * * *'
+on: workflow_call
+  # workflow_dispatch:
+  # schedule:
+  #   - cron:  '0 0 * * *'
 
 permissions:
   contents: read
@@ -27,28 +27,32 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Install apt packages
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y cmake hwloc libhwloc-dev libnuma-dev libtbb-dev
-
-      - name: Configure CMake
-        run: >
-          cmake
-          -B ${{github.workspace}}/build
-          -DCMAKE_BUILD_TYPE=${{matrix.build_type}}
-          -DCMAKE_C_COMPILER=${{matrix.compiler.c}}
-          -DCMAKE_CXX_COMPILER=${{matrix.compiler.cxx}}
-          -DUMF_TESTS_FAIL_ON_SKIP=ON
-          -DUMF_DEVELOPER_MODE=ON
-          -DUMF_BUILD_FUZZTESTS=ON
+      # - name: Build Docker image
+      #   run: |
+      #     docker build -f .github/docker/ubuntu-20.04.Dockerfile -t umf-ubuntu-20.04 .   
 
-      - name: Build
-        run: cmake --build ${{github.workspace}}/build --config ${{matrix.build_type}} --verbose -j$(nproc)
-
-      - name: Fuzz long test
-        working-directory: ${{github.workspace}}/build
-        run: ctest -C ${{matrix.build_type}} --output-on-failure --verbose -L "fuzz-long"
+      - name: Fuzz long test in Docker container
+        run: |
+          docker run --rm \
+            -v ${{github.workspace}}:/workspace \
+            -w /workspace \
+            --env BUILD_TYPE=${{matrix.build_type}} \
+            --user root \
+            umf-ubuntu-20.04 \
+            bash -c "
+              export VALGRIND_LIB=/usr/lib/valgrind/ &&
+              apt-get update &&
+              apt-get install -y cmake hwloc libhwloc-dev libnuma-dev libtbb-dev &&
+              cmake -B /workspace/build \
+                -DCMAKE_BUILD_TYPE=\$BUILD_TYPE \
+                -DCMAKE_C_COMPILER=${{matrix.compiler.c}} \
+                -DCMAKE_CXX_COMPILER=${{matrix.compiler.cxx}} \
+                -DUMF_TESTS_FAIL_ON_SKIP=ON \
+                -DUMF_DEVELOPER_MODE=ON \
+                -DUMF_BUILD_FUZZTESTS=ON &&
+              cmake --build /workspace/build --config \$BUILD_TYPE --verbose -j$(nproc) &&
+              ctest -C \$BUILD_TYPE --output-on-failure --verbose -L "fuzz-long"
+          "
 
   valgrind:
     name: Valgrind
@@ -64,30 +68,34 @@ jobs:
       with:
         fetch-depth: 0
 
-    - name: Install apt packages
-      run: |
-        sudo apt-get update
-        sudo apt-get install -y cmake hwloc libhwloc-dev libnuma-dev libtbb-dev valgrind
-
-    - name: Configure CMake
-      run: >
-        cmake
-        -B ${{github.workspace}}/build
-        -DCMAKE_BUILD_TYPE=Debug
-        -DUMF_FORMAT_CODE_STYLE=OFF
-        -DUMF_DEVELOPER_MODE=ON
-        -DUMF_BUILD_LIBUMF_POOL_DISJOINT=ON
-        -DUMF_BUILD_LIBUMF_POOL_JEMALLOC=ON
-        -DUMF_BUILD_LEVEL_ZERO_PROVIDER=OFF
-        -DUMF_BUILD_CUDA_PROVIDER=OFF
-        -DUMF_USE_VALGRIND=1
-        -DUMF_TESTS_FAIL_ON_SKIP=ON
+    # - name: Build Docker image
+    #   run: |
+    #     docker build -f .github/docker/ubuntu-20.04.Dockerfile -t umf-ubuntu-20.04 .
 
-    - name: Build
-      run: cmake --build ${{github.workspace}}/build --config Debug -j$(nproc)
-
-    - name: Run tests under valgrind
-      run: ${{github.workspace}}/test/test_valgrind.sh ${{github.workspace}} ${{github.workspace}}/build ${{matrix.tool}}
+    - name: Run tests under valgrind in Docker
+      run: |
+        docker run --rm \
+          -v ${{github.workspace}}:/workspace \
+          -w /workspace \
+          --env TOOL=${{ matrix.tool }} \
+          --user root \
+          umf-ubuntu-20.04 \
+          bash -c "\
+            apt-get update &&
+            apt-get install -y cmake hwloc libhwloc-dev libnuma-dev libtbb-dev valgrind &&
+            cmake -B /workspace/build \
+              -DCMAKE_BUILD_TYPE=Debug \
+              -DUMF_FORMAT_CODE_STYLE=OFF \
+              -DUMF_DEVELOPER_MODE=ON \
+              -DUMF_BUILD_LIBUMF_POOL_DISJOINT=ON \
+              -DUMF_BUILD_LIBUMF_POOL_JEMALLOC=ON \
+              -DUMF_BUILD_LEVEL_ZERO_PROVIDER=OFF \
+              -DUMF_BUILD_CUDA_PROVIDER=OFF \
+              -DUMF_USE_VALGRIND=1 \
+              -DUMF_TESTS_FAIL_ON_SKIP=ON &&
+            cmake --build /workspace/build --config Debug -j$(nproc) &&
+            /workspace/test/test_valgrind.sh /workspace /workspace/build \$TOOL
+        "
 
   # TODO fix #843
   #icx:

.github/workflows/pr_push.yml

@@ -20,6 +20,8 @@ jobs:
     uses: ./.github/workflows/reusable_checks.yml
   DocsBuild:
     uses: ./.github/workflows/reusable_docs_build.yml
+  Nightly:
+    uses: ./.github/workflows/nightly.yml
   FastBuild:
     name: Fast builds
     needs: [CodeChecks, DocsBuild]

CMakeLists.txt

@@ -33,6 +33,13 @@ include(CMakePackageConfigHelpers)
 include(GNUInstallDirs)
 find_package(PkgConfig)
 
+find_package(Valgrind REQUIRED)
+if(Valgrind_FOUND)
+    message(STATUS "Found Valgrind!")
+else()
+    message(FATAL_ERROR "Valgrind not found!")
+endif()
+
 # Define a list to store the names of all options
 set(UMF_OPTIONS_LIST "")
 list(APPEND UMF_OPTIONS_LIST CMAKE_BUILD_TYPE)

cmake/FindVALGRIND.cmake

@@ -0,0 +1,22 @@
+# Copyright (C) 2025 Intel Corporation
+# Under the Apache License v2.0 with LLVM Exceptions. See LICENSE.TXT.
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+if(NOT VALGRIND_ROOT AND DEFINED ENV{VALGRIND_ROOT})
+	set(VALGRIND_ROOT "$ENV{VALGRIND_ROOT}" CACHE PATH "Valgrind base directory location (optional, used for nonstandard installation paths)")
+	mark_as_advanced(VALGRIND_ROOT)
+endif()
+
+# Search path for nonstandard locations
+if(VALGRIND_ROOT)
+	set(Valgrind_INCLUDE_PATH PATHS "${VALGRIND_ROOT}/include"  "${VALGRIND_ROOT}/valgrind/current/usr/include" NO_DEFAULT_PATH)
+	set(Valgrind_BINARY_PATH PATHS "${VALGRIND_ROOT}/bin" NO_DEFAULT_PATH)
+endif()
+
+find_path(Valgrind_INCLUDE_DIR valgrind/memcheck.h HINTS ${Valgrind_INCLUDE_PATH})
+find_program(Valgrind_EXECUTABLE NAMES valgrind PATH ${Valgrind_BINARY_PATH}) 
+
+include(FindPackageHandleStandardArgs)
+find_package_handle_standard_args(Valgrind DEFAULT_MSG Valgrind_INCLUDE_DIR Valgrind_EXECUTABLE)
+
+mark_as_advanced(Valgrind_INCLUDE_DIR Valgrind_EXECUTABLE)

third_party/requirements.txt

@@ -6,15 +6,15 @@ black==24.3.0
 # Tests
 packaging==24.2
 # Generating HTML documentation
-pygments==2.19.1
-sphinxcontrib_applehelp==2.0.0
-sphinxcontrib_devhelp==2.0.0
-sphinxcontrib_htmlhelp==2.1.0
-sphinxcontrib_serializinghtml==2.0.0
-sphinxcontrib_qthelp==2.0.0
+pygments==2.18.0
+sphinxcontrib_applehelp==1.0.0
+sphinxcontrib_devhelp==1.0.0
+sphinxcontrib_htmlhelp==2.0.1
+sphinxcontrib_serializinghtml==1.1.5
+sphinxcontrib_qthelp==1.0.3
 breathe==4.35.0
-sphinx==8.1.3
-sphinx_book_theme==1.1.3
+sphinx==7.1.2
+sphinx_book_theme==1.0.1
 # Spelling check in documentation
 pyenchant==3.2.2
 sphinxcontrib-spelling==8.0.0