Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] compat #1063

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[DRAFT] compat #1063

wants to merge 1 commit into from

Conversation

bratpiorka
Copy link
Contributor

TODO

@bratpiorka bratpiorka force-pushed the rrudnick_compat_wflow branch 3 times, most recently from b4226c3 to a341c50 Compare January 29, 2025 11:25
lplewa
lplewa reviewed Jan 29, 2025
View reviewed changes
src/memory_provider.c Outdated
@@ -173,7 +173,11 @@ umf_result_t umfMemoryProviderCreate(const umf_memory_provider_ops_t *ops,
return UMF_RESULT_ERROR_OUT_OF_HOST_MEMORY;
}

assert(ops->version == UMF_VERSION_CURRENT);
if (ops->version == UMF_VERSION_CURRENT) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@bratpiorka bratpiorka force-pushed the rrudnick_compat_wflow branch 4 times, most recently from b4edc5c to 6baaa70 Compare January 29, 2025 17:16
@bratpiorka bratpiorka mentioned this pull request Jan 29, 2025
Open
PatKamin
PatKamin reviewed Jan 30, 2025
View reviewed changes
.github/workflows/reusable_compatibility.yml
name: Ubuntu
strategy:
matrix:
# TODO other systems?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that one Ubuntu and one Windows job is needed.

.github/workflows/reusable_compatibility.yml
- name: Set ptrace value for IPC test
run: sudo bash -c "echo 0 > /proc/sys/kernel/yama/ptrace_scope"

- name: Run "tag" UMF tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we need to test the tag, it was surely already tested before the merge of a commit. I think we could just build it here for the latest version tests run.

PatKamin
PatKamin reviewed Jan 30, 2025
View reviewed changes
src/memory_provider.c Outdated
umf_memory_provider_ops_10_0_t ops_10_0;
memcpy(&ops_10_0, ops, sizeof(ops_10_0));

provider->ops.version = UMF_PROVIDER_OPS_VERSION_CURRENT;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not leaving it to 0.10?

@bratpiorka bratpiorka force-pushed the rrudnick_compat_wflow branch 7 times, most recently from db03802 to bf8dea7 Compare January 30, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatKamin PatKamin PatKamin left review comments

@lplewa lplewa lplewa left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bratpiorka @lplewa @PatKamin